Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more documents to build for Android <= 30 #412

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Add more documents to build for Android <= 30 #412

merged 1 commit into from
Oct 20, 2021

Conversation

Taym95
Copy link
Collaborator

@Taym95 Taym95 commented Oct 11, 2021

Copy link
Contributor

@remonh87 remonh87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks! let's add the issue and ship it

@@ -218,6 +218,12 @@ Up to SDK 30 (Android 11):
* ACCESS_FINE_LOCATION : this permission is needed because old Nexus devices need location services in order to provide reliable scan results
* BLUETOOTH : allows apps to connect to a paired Bluetooth device
* BLUETOOTH_ADMIN: allows apps to discover and pair Bluetooth devices
* BLUETOOTH_SCAN: add this permission with `tools:node="remove"` to remove it from the merged manifest.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a reference to this issue so ppl know what to do when they get a similar issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added issue

@remonh87 remonh87 merged commit 37b0c6c into PhilipsHue:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants