Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank feature query function typing fixes #3160

Merged

Conversation

jurgisnosto
Copy link
Contributor

@jurgisnosto jurgisnosto commented Sep 20, 2024

Description

This PR fixes incorrect typings in rank feature saturation, sigmoid and log query functions. More specifically, pivot and scaling_factor fields should accept floats instead of integers. This can be confirmed for each function:

Official docs can be found here.

Context

The error was encounter while migrating from the deprecated high level rest client to elastic4s. We are using saturation function with float values which cannot be changed, so the migration is on hold until the PR is merged. Please let me know if you need any additional input from me

@Philippus
Copy link
Owner

Nice catch! I think the examples threw me off, as they only show whole numbers.

@Philippus Philippus merged commit 01653f8 into Philippus:main Sep 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants