Rank feature query function typing fixes #3160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes incorrect typings in rank feature
saturation
,sigmoid
andlog
query functions. More specifically,pivot
andscaling_factor
fields should accept floats instead of integers. This can be confirmed for each function:Official docs can be found here.
Context
The error was encounter while migrating from the deprecated high level rest client to elastic4s. We are using saturation function with float values which cannot be changed, so the migration is on hold until the PR is merged. Please let me know if you need any additional input from me