Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to actually upload the files to an ftps server using curl. I used the same method that
trigger_inotify.sh
uses so if the FTP env vars are empty or unset the scripts will still work.I marked this PR as a draft because it has changes that my other PRs have and therefore should go in after those PRs.
Also, after I worked on these code changes I worked on using the
ocrmypdf
tool to provide ocr capabilities. ocrmypdf wasn't available in Ubuntu 16.04 so I upgraded the base image to use ubuntu 20.04. After upgrading to Ubuntu 20.04, curl ran into an issue while uploading to the ftps server (I think it was this bug), so I switched to usinglftp
. I have the code mostly ready for all those changes but I'll wait until the current PRs I submitted are merged before I submit them.Also just wanted to thank you for creating this repo and making it public, it helped me get started getting my brother scanner to work better.