Fix api usage with custom name environment variable

[pedropombeiro]

Closes #55

[PhilippMundhenk]

We can also move this to master directly, as it fixes a small issue. No need to go via development, I think

[pedropombeiro]

I'll let you know when it is working. I'm still having a problem with env var expansion.

[pedropombeiro]

@PhilippMundhenk I can now scan through a curl command (even from outside the container), but nothing happens when I do it from the web UI (the button stays pressed but no scanner activity).

[PhilippMundhenk]

Could it be a Javascript issue? Have you tried calling the /scan.php URL from browser? Does this trigger (this is effectively what the JS does)? Any Javascript issues showing up in the browser console (F12)?

[pedropombeiro]

Ah yes:

[PhilippMundhenk]

uhm. I'm lost. This looks like perfectly good JS to me. I would put a { there... Are you testing on master?
@vgarcia007: You have more experience with JS. Any ideas?

[pedropombeiro]

I'm testing on this branch. It did work from the browser if I put the final URL there.

[PhilippMundhenk]

Could you try another browser?

[pedropombeiro]

Could you try another browser?

That's the first thing I tried (Safari on mobile, after Edge on desktop)

[PhilippMundhenk]

oooooh, the linting! elseif vs else if. The latter is js, the earlier the correction after linting: 729851c

[PhilippMundhenk]

This should do it

[pedropombeiro]

That worked! 👍

[StarTakko]

Hi, when will it be moved to master? 😁

[PhilippMundhenk]

I'll let you know when it is working. I'm still having a problem with env var expansion.

Hi @pedropombeiro, did you manage to fix this? Is there anything missing to merge this?

[pedropombeiro]

@PhilippMundhenk it is working for me, after your fix of the else if.

[PhilippMundhenk]

Ok, lets put this to develpoment and I extracted your fix to apply directly to master as well, in #58.

[PhilippMundhenk]

@StarTakko : This PR is going through our development branch first, since the changes are based on the Python rewrite, but a fix for the custom naming should be in master today, via #58 . Thank you for the hint!