Add linters to CI pipeline #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedropombeiro
force-pushed
the
pedropombeiro/add-superlinter-ci-job
branch
8 times, most recently
from
84f134c to
59fa9f7
Compare
pedropombeiro
changed the base branch from
master
to
pedropombeiro/convert-to-python3
pedropombeiro
force-pushed
the
pedropombeiro/add-superlinter-ci-job
branch
2 times, most recently
from
18b8389 to
10d4d1d
Compare
pedropombeiro
force-pushed
the
pedropombeiro/add-superlinter-ci-job
branch
from
10d4d1d to
a4898f2
Compare
PhilippMundhenk
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
I like it! At some points we might even want to make passing mandatory, but I also like the idea to give us some time. I, personally, will need it, if you don't always want to fix all of my errors :P
Is this intended to go into your branch or straight to master?
This can go directly to master. |
pedropombeiro
merged commit 25a7254
into
pedropombeiro/convert-to-python3
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CI job to flag any linting errors. It currently reports but ignores any errors, providing visibility without breaking the pipeline.