Cleanup Dockerfile #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedropombeiro
force-pushed
the
pedropombeiro/cleanup-Dockerfile
branch
from
a6c14e1 to
003a991
Compare
pedropombeiro
force-pushed
the
pedropombeiro/cleanup-Dockerfile
branch
5 times, most recently
from
686ae0c to
3b43f74
Compare
pedropombeiro
force-pushed
the
pedropombeiro/cleanup-Dockerfile
branch
from
3b43f74 to
ce05ff2
Compare
|
I like it! The size of the image has long bothered me. In fact, it is still massive for what it does. I feel that it should be possible to get a scanner driver under 700MB -.- |
The linter says it has been deprecated since a long time. We can keep it if you prefer though. |
|
:O Is it? I wasn't aware of that. It's still in the reference. Anyway, let's take it out then. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tries to minimize the size of the resulting image (by reducing layers, and not installing optional tools), and also allow specifying a
brscan-skey.config(which will later allow us to use Python scripts directly).Comparison between images (new image on the bottom):
It went from 1.1 GB to 764 MB (30% reduction with no change in functionality), and efficiency from 97 % to 99 %.
I've also linted the Dockerfile at https://www.fromlatest.io/ and implemented some of the suggestions.