Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing NAME variable #47

Merged

Conversation

PhilippMundhenk
Copy link
Owner

@PhilippMundhenk PhilippMundhenk commented Sep 23, 2024

This should fix the way that the NAME shows up on the printer. Addresses #20

@PhilippMundhenk PhilippMundhenk marked this pull request as draft September 23, 2024 18:46
@PhilippMundhenk
Copy link
Owner Author

PhilippMundhenk commented Sep 23, 2024

@pedropombeiro : How did you manage to see the name on the scanner? When I have only one container running, for my scanner, the name never shows up. I think this should work, but I can't really test this, as I don't have an option to run the container twice (ports, etc.). Is there another way to see the name on the scanner?

If you have a quick way to test, I would also be happy. You can do this via ghcr.io/philippmundhenk/brotherscannerdocker:20-printer-always-displays-qnap-machine-name-as-username

@pedropombeiro
Copy link
Collaborator

@PhilippMundhenk I installed their software on my laptop, and then you have to choose. But it is also visible with only one server, once you start a scan. It is displayed on the scanner display.

@PhilippMundhenk
Copy link
Owner Author

I NEVER NOTICED THAT! I never really read what it says on the display, have been training muscle memory for years just pushing the same combination of buttons for front and rear pages. I never noticed it actually says the name there. Anyway, it works! ;)

@PhilippMundhenk PhilippMundhenk marked this pull request as ready for review September 23, 2024 19:11
@pedropombeiro pedropombeiro merged commit 898ec94 into master Sep 23, 2024
1 check passed
@pedropombeiro
Copy link
Collaborator

Thanks for fixing this, @PhilippMundhenk!

@PhilippMundhenk PhilippMundhenk deleted the 20-printer-always-displays-qnap-machine-name-as-username branch September 25, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants