Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit script if scan cancelled #35

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Conversation

pedropombeiro
Copy link
Collaborator

Currently, the script continues to execute if the user cancels the scan on the scanner control panel. We should exit in that situation.

@pedropombeiro pedropombeiro force-pushed the pedropombeiro/exit-on-error branch 2 times, most recently from 19b6a5e to b812602 Compare September 22, 2024 17:38
@PhilippMundhenk
Copy link
Owner

lgtm, but waiting with merge until after #38

Copy link
Owner

@PhilippMundhenk PhilippMundhenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pedropombeiro pedropombeiro force-pushed the pedropombeiro/exit-on-error branch from b812602 to fffcc05 Compare September 22, 2024 18:34
@PhilippMundhenk PhilippMundhenk merged commit 5cee3b9 into master Sep 22, 2024
1 check passed
@pedropombeiro pedropombeiro deleted the pedropombeiro/exit-on-error branch September 22, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants