Fix temp directories left behind

[pedropombeiro]

My last change to scantofile-0.2.4-1.sh unfortunately introduced a bug where the rm -rf command was not being applied to a correctly named directory. This PR fixes it and further cleans up the scripts to make more use of variables to avoid repetition.

[pedropombeiro]

note: Explicitly specify --format=pnm to avoid unnecessary warning fallback message.

[PhilippMundhenk]

Looks pretty good. Two things though:

• It is possible that the script is called from web interface, without parameters, thus $1 will not contain the device. In this case, we need to call scan_cmd without device set, as this will use the default device. A simple "if" should suffice.
• Let's push that to a branch, as this will trigger the git action to build a separate container that can be tested easily by pulling from ghcr

[pedropombeiro]

It is possible that the script is called from web interface, without parameters, thus $1 will not contain the device. In this case, we need to call scan_cmd without device set, as this will use the default device. A simple "if" should suffice.

@PhilippMundhenk Keep in mind that $device is not being used at the moment. The only thing we're doing is passing it to scan_cmd.

[PhilippMundhenk]

Yes, indeed, by passing it there, if being called from the web interface, $device is empty, thus passing --device-name="" leading to a SegFault of the driver. Thus, we should only pass this parameter, if we have it set correctly (i.e., called from buttons, not web interface).

[pedropombeiro]

Yes, indeed, by passing it there, if being called from the web interface, $device is empty, thus passing --device-name="" leading to a SegFault of the driver. Thus, we should only pass this parameter, if we have it set correctly (i.e., called from buttons, not web interface).

@PhilippMundhenk can you please point me to where we're passing --device-name=""?

[PhilippMundhenk]

We aren't. Starting to see ghosts switching between issues and branches. It is passed to scan_cmd, but never to scanimage from there.

[PhilippMundhenk]

Merged this to branch, will do a quick test of the branch, once container is ready, then merge to master