Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NPE when use solid color with barchart #4802

Merged
merged 4 commits into from
Feb 9, 2020
Merged

fix NPE when use solid color with barchart #4802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cef967f
fix NPE when use solid color with barchart
Feb 7, 2020
4b67673
Update BarChartRenderer.java
oatrice Feb 7, 2020
33240f9
Update HorizontalBarChartRenderer.java
oatrice Feb 7, 2020
90e5230
Update BarChartRenderer.java
oatrice Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MPChartLib/src/main/java/com/github/mikephil/charting/renderer/BarChartRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ protected void drawDataSet(Canvas c, IBarDataSet dataSet, int index) {

trans.pointValuesToPixel(buffer.buffer);

final boolean isCustomFill = dataSet.getFills().size() > 0;
final boolean isCustomFill = dataSet.getFills() != null && !dataSet.getFills().isEmpty();
final boolean isSingleColor = dataSet.getColors().size() == 1;
final boolean isInverted = mChart.isInverted(dataSet.getAxisDependency());

Expand Down
2 changes: 1 addition & 1 deletion ...rtLib/src/main/java/com/github/mikephil/charting/renderer/HorizontalBarChartRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ protected void drawDataSet(Canvas c, IBarDataSet dataSet, int index) {

trans.pointValuesToPixel(buffer.buffer);

final boolean isCustomFill = dataSet.getFills().size() > 0;
final boolean isCustomFill = dataSet.getFills() != null && !dataSet.getFills().isEmpty();
final boolean isSingleColor = dataSet.getColors().size() == 1;
final boolean isInverted = mChart.isInverted(dataSet.getAxisDependency());

Expand Down