Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CORS issue in APIHUB #1143

Closed
salboaie opened this issue Dec 22, 2022 · 3 comments
Closed

Fix CORS issue in APIHUB #1143

salboaie opened this issue Dec 22, 2022 · 3 comments
Assignees
@asaccool @skutner

Comments

@salboaie
Copy link
Member

salboaie commented Dec 22, 2022 •
edited by skutner
Loading

Refactor responseHeader middleware to set headers for specific paths
@salboaie salboaie changed the title Proper headers by default for CORS in APIHUB Better default for CORS in APIHUB and helm charts Dec 22, 2022
@asaccool
Copy link
Contributor

check the list of allowed headers to include some needed headers like epiprotocolversion and others

@jaravan1
Copy link

related with #1107

@jaravan1 jaravan1 mentioned this issue Dec 23, 2022
Closed
@skutner skutner changed the title Better default for CORS in APIHUB and helm charts Fix CORS issue in APIHUB Jan 3, 2023
@salboaie
Copy link
Member Author

salboaie commented Jan 4, 2023

Solution:
each component that inserts require custom headers will have a way to register them so the CORS component is capable to get a correct answer without additional configurations

asaccool added a commit to OpenDSU/apihub that referenced this issue Jan 4, 2023
@asaccool
PharmaLedger-IMI/epi-workspace#1143 - added a new mechanism to allow …
9e59118 
…custom components to register new headers for the CORS response if needed
asaccool added a commit to PharmaLedger-IMI/gtin-resolver that referenced this issue Jan 4, 2023
@asaccool
PharmaLedger-IMI/epi-workspace#1143 registering the epiprotocolversio…
c9e7b5a 
…n header for a proper CORS response
@adiganga2002 adiganga2002 mentioned this issue Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asaccool asaccool

@skutner skutner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@salboaie @asaccool @skutner @adiganga2002 @jaravan1