Add support for Raw Events #38
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for the PR! LGTM with one comment about the example. The values don't work on my machine (not surprising) so having a comment on what platform/vendor they're supposed to work on would be helpful.
I've added a few different changes to make it a bit easier to use in the common case, improve documentation, and clean up things a bit.
| let insns_retired: Raw = Raw::new(0x08); | ||
| let cpu_cycles: Raw = Raw::new(0x11); |
There was a problem hiding this comment.
Do you have a link or somewhere that describes where these values come from and what platform they're valid for? The example is useful but not likely to work on most people's machines. At the very minimum a comment describing what platform this is expected to work on would be useful.
There was a problem hiding this comment.
Ah. These are armv8 pmu events. I was using the Neoverse Technical reference: https://developer.arm.com/documentation/100616/0400/debug-descriptions/performance-monitor-unit/pmu-events.
|
Again, thanks for the PR! I'll put out a new release later tonight when I have the time. |
Same as jimblandy/perf-event#25