MDL-82932 mod_data: Fix export with userdata of deleted users

PhMemmel · Nov 11, 2024 · 5cceecc · 5cceecc
1 parent 2b337b4
commit 5cceecc
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/mod/data/classes/local/exporter/utils.php b/mod/data/classes/local/exporter/utils.php
@@ -123,9 +123,10 @@ public static function data_exportdata(int $dataid, array $fields, array $select
                 }
                 if ($userdetails) { // Add user details to the export data.
                     $userdata = get_complete_user_data('id', $record->userid);
-                    $exporter->add_to_current_row(fullname($userdata));
-                    $exporter->add_to_current_row($userdata->username);
-                    $exporter->add_to_current_row($userdata->email);
+                    // In case of an already deleted user, we do not receive any userdata and export an empty string instead.
+                    $exporter->add_to_current_row($userdata ? fullname($userdata) : '');
+                    $exporter->add_to_current_row($userdata ? $userdata->username : '');
+                    $exporter->add_to_current_row($userdata ? $userdata->email : '');
                 }
                 if ($time) { // Add time added / modified.
                     $exporter->add_to_current_row(userdate($record->timecreated));