Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum version of Perl to 5.14 #1682

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

cromedome
Copy link
Contributor

Moo now has a minimum version of Perl 5.14, and without Moo, we have nothing.

Moo now has a minimum version of Perl 5.14, and without Moo, we have
nothing.
@cromedome cromedome merged commit 9130bf4 into master Aug 1, 2023
@cromedome cromedome deleted the enhancement/perl-5.14 branch August 1, 2023 01:41
cromedome added a commit that referenced this pull request Oct 9, 2023
    [ BUG FIXES ]
    * GH #1663: Allow overriding of prefix in add_route (GeekRuthie)
    * GH #1675: Stringify VERSION_FROM correctly in Makefile.PL (Jason
      A. Crome)
    * GH #1677: Don't deserialize multipart form data on post (Emil
      Perhinschi)
    * GH #1694: Update JS assets in Dancer2 app skel (Jason A. Crome)

    [ ENHANCEMENTS ]
    * PR #1682: Bump minimum version of Perl to 5.14 (Jason A. Crome)

    [ DOCUMENTATION ]
    * GH #1580: Document the purpose of the .dancer file (Jason A. Crome)
    * GH #1669: Show correct usage of Dancer2::Core::Error (GeekRuthie)
    * GH #1674: Fix POD for input_handle() (mauke)
    * GH #1414: Add documentation resources to the doc map (Jason A.
      Crome, Yanick Champoux)
    * PR #1684: Remove shumphrey from core developers (Steven Humphrey)
    * GH #1685: Document the versioning scheme and Dancer2 release
      process (Jason A. Crome)
    * PR #1688: Fixed various bugs/issues in Dancer2 Pod (Jason A. Crome)
    * PR #1691: Update the contribution guidelines (Jason A. Crome)
    * PR #1692: Change README extension .mkdn -> .md (Jason A. Crome)

    [ DEPRECATED ]
    * GH #1645: Deprecated Dancer2::Test (Jason A. Crome)
    * GH #1646: Deprecated keyword: push_header (Jason A. Crome)
    * GH #1647: Deprecated keyword: header (Jason A. Crome)
    * GH #1648: Deprecated keyword: headers (Jason A. Crome)
    * GH #1649: Deprecated keyword: context (Jason A. Crome)
    * GH #1650: Deprecated: splat/capture named placeholders (Jason A.
      Crome)
    * GH #1651: Deprecated core Request instance method:
      request->dispatch_path (Jason A. Crome)
    * GH #1652: Deprecated keyword in plugins: plugin_setting (Jason A.
      Crome)
    * GH #1653: Deprecated keyword in plugins: dancer_app (Jason A. Crome)
    * GH #1654: Deprecated keyword in plugins: request (Jason A. Crome)
    * GH #1655: Deprecated keyword in plugins: var (Jason A. Crome)
    * GH #1656: Deprecated keyword in plugins: hook (Jason A. Crome)

    [ MISC ]
    * GH #1659: Rename `master` branch to be `main` (Yanick Champoux)
@grr
Copy link

grr commented Oct 9, 2023

Moo now has a minimum version of Perl 5.14,

i see no evidence of this statement. can't even find a branch or PR in the Moo repo to back this up.

@GeekRuthie
Copy link
Contributor

You're both right here--to a point. According to this link in the current Moo docs, if you're going to run it prior to 5.14, it will likely require additional dependencies.

Moo should run on versions farther back with those additional dependencies, just as Dancer likely will run on older versions of Perl, going back a good ways. But there's no guarantee it will do so, and we do not support work dependent on those older Perls.

The decision by the Core Team has been made to follow the Toolchain Gang's decision in the Lyon Amendment; our commitment is to support versions of Perl that are ten years or newer--as of this writing, 5.16, and in 2024, 5.20. So both this ticket and #1643 are pretty much moot, really.

It sounds like you're picking at a nit here, @grr, especially given you also responded to #1643 in a very similar fashion. Is there a reason for this, something with code you're using or building that requires older Perls?

@PerlDancer PerlDancer locked as resolved and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants