Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/engine namespaces 1323 #1577

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

veryrusty
Copy link
Member

Draft implementation to allow fully qualified namespaces for all engines, as discussed some time ago in #1323.

Draft PR before I go write more tests / documentation to ensure this is where we want to go:

  set engines => {
    serialier => {
      'My::Awesome::Serializer => { ... },
    },
    template => {
      'My::Template::DWIM => { ... }.
    },
  };
  set serializer => `+My::Awesome::Serializer`;
  set template => `+My::Template::DWIM`;

Similarly to what DBIC allows, the full namespace to any engine can be
specified with a leading `+`. i.e.

  set serialier => '+My::Awesome::Serializer';

will DWIM.
@veryrusty
Copy link
Member Author

@SysPete @racke @cromedome thoughts ?

@racke
Copy link
Member

racke commented Jan 13, 2021

Sounds good to me. 👍

@racke
Copy link
Member

racke commented Jan 13, 2021

Just make sure that you don't repeat the serialier typo in the documentation.


 set engines => {
    serialier => {
      'My::Awesome::Serializer => { ... },
    },
    template => {
      'My::Template::DWIM => { ... }.
    },
  };

@SysPete
Copy link
Member

SysPete commented Jan 13, 2021

@veryrusty 👍 for using + as a FQ namespace indicator as it follows a pattern used elsewhere. Very happy to see this, thank you!

@cromedome
Copy link
Contributor

Yes! 👍 I like what you've done here! Please keep running with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants