Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return empty string instead of "0" #1079

Closed
ambs opened this issue Dec 26, 2015 · 3 comments
Closed

Return empty string instead of "0" #1079

ambs opened this issue Dec 26, 2015 · 3 comments
Labels
Bug Up for grabs

Comments

@ambs
Copy link
Member

ambs commented Dec 26, 2015

Hi
If a route returns "0", it gets "" at the end.
This is something recent, but looking to the commit descriptions didn't find the reason why.

Is this a feature or a bug? If it is a but (I think so) I can dig it up. Should be a missing call to defined.
@xsawyerx
Copy link
Member

I would classify this as a bug!

@ambs ambs mentioned this issue Dec 26, 2015
Closed
@ambs
Copy link
Member Author

ambs commented Dec 26, 2015

Faster than I though.

@veryrusty veryrusty mentioned this issue Dec 28, 2015
Closed
@veryrusty
Copy link
Member

Closed by #1082.

@ambs++ for reporting and thanks for the initial PR!.

xsawyerx added a commit that referenced this issue Jan 12, 2016
@xsawyerx
v0.166000
21a919d 
    [ BUG FIXES ]
    * GH #1013, #1092: Remove race condition caused by caching available
      engines. (Sawyer X, Menno Blom, Russell Jenkins)
    * GH #1089: Exact macthing of route regex comments for tokens/splats.
      (Sawyer X)
    * GH #1079, #1082: Allow routes to return '0' as response content,
      and serializer hooks are called when default response content is
      to be returned. (Alberto Simões, Russell Jenkins)
    * GH #1093, 1095: Use a dynamic TT2 INCLUDE_PATH to allow relative
      views with relative includes; fixing regression introduced by #1037.
      (Russell Jenkins)
    * GH #1096, #1097: Return compatibility on Perl 5.8.x!
      (Peter Mottram - @SysPete)

    [ DOCUMENTATION ]
    * GH #1076: Typo in Dancer2::Core::Hook POD. (Jonathan Scott Duff)

    [ ENHANCEMENTS ]
    * GH #1074: Add sample session engine config to skeleton app.
      (Peter Mottram - @SysPete)
    * GH #1088: Return route objects when defining new routes.
      (Sawyer X)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Up for grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xsawyerx @veryrusty @ambs