Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable "Useless use of %s in void context" warning for chained comparisons #22969

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Enable "Useless use of %s in void context" warning for chained comparisons #22969

merged 1 commit into from
Feb 9, 2025

Conversation

t-a-k
Copy link
Contributor

@t-a-k t-a-k commented Feb 1, 2025

This particular warning was not issued for chained comparisons such as 1 < $a < 2 in void context.

% perl -we '$a = 1.5; 1 < $a'
Useless use of numeric lt (<) in void context at -e line 1.
% perl -we '$a = 1.5; 1 < $a < 2'
%		# (no warnings)

This change will enable the warning for such cases.

  • This set of changes requires a perldelta entry, and it is included.

@t-a-k
op.c: Enable "Useless use of %s in void context" warning for chained …
dbb176d 
…comparisons

This particular warning is not issued for chained comparisons such as
`1 < $a < 2` in void context before this change.

t/lib/warnings/op: Add tests for this warning.
@scottchiefbaker
Copy link
Contributor

Interesting. Good catch.

@richardleach
Copy link
Contributor

LGTM

@mauke mauke merged commit 225c128 into Perl:blead Feb 9, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauke mauke mauke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-a-k @scottchiefbaker @richardleach @mauke