Fix some build issues with clang in Mingw-w64

[Biswa96]

No description provided.

[jkeenan]

Thank you for this pull request. I suspect that this p.r. may be attempting to do too much and that p.r.s addressing separate problems may be better.

Specifically, until we can see the build-time warnings you are getting when compiling with clang on Mingw-w64, we can't evaluate your proposed changes to perl.h. Because perl.h is very fundamental to compilation, we have to be very careful before changing it.

We keep track of build-time warnings with a GitHub "label" by that name. Can you please open a separate Issue for the build-time warnings, pasting in the relevant parts of the make (or Windows equivalent) output and the relevant configuration options?

Thank you very much.
Jim Keenan

[Biswa96]

I think you've already opened the issue here #18780

[jkeenan]

I think you've already opened the issue here #18780

As noted in #18780 (comment) today, I tried out your pull request and found that it eliminated the vast majority of build-time warnings discussed in #18780. The warnings it does not eliminate appear to come from files under dist/ rather than from perl.h.

I'm not in a position to evaluate the mingw-related parts of this pull request. Nor can I say whether this is the best way to eliminate approximately 28,000 build-time warnings; only that is a way to eliminate such warnings. I don't have access to more recent versions of clang (clang13, I think, is relevant).

So a qualified +1 to this p.r.

[jkeenan]

@Biswa96, can you confirm that the changes in this commit are consistent with your proposed changes to perl.h and help to eliminate build-time warnings when compiling with clang12?

Reference: #18780

Thank you very much.
Jim Keenan

[jkeenan]

I think you've already opened the issue here #18780

As noted in #18780 (comment) today, I tried out your pull request and found that it eliminated the vast majority of build-time warnings discussed in #18780. The warnings it does not eliminate appear to come from files under dist/ rather than from perl.h.

I'm not in a position to evaluate the mingw-related parts of this pull request. Nor can I say whether this is the best way to eliminate approximately 28,000 build-time warnings; only that is a way to eliminate such warnings. I don't have access to more recent versions of clang (clang13, I think, is relevant).

So a qualified +1 to this p.r.

@xenu, are you in a position to review the mingw-related parts of this p.r.?

Thank you very much.
Jim Keenan

[jkeenan]

@Biswa96,

Thank you for providing this pull request, which helped focus discussion of the problem of build-time warnings with clang12.

In #18984, @tonycoz has provided a more focused version of your patch, which we have applied to blead.

That leaves the 3 mingw-focused commits which were part of your p.r. If you would like to pursue those further, please open a new p.r. with just mingw-focused commits.

Closing this pull request. Thank you very much.