Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TagBot GHA; add CompatHelper and CI GHAs #11

Merged
merged 9 commits into from
May 28, 2023
Merged

Update TagBot GHA; add CompatHelper and CI GHAs #11

merged 9 commits into from
May 28, 2023

Conversation

PerezHz
Copy link
Owner

@PerezHz PerezHz commented May 25, 2023

Fixes #10. Also updates TagBot GHA.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@d2d75e3). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             main     #11   +/-   ##
======================================
  Coverage        ?   4.82%           
======================================
  Files           ?      18           
  Lines           ?    7497           
  Branches        ?       0           
======================================
  Hits            ?     362           
  Misses          ?    7135           
  Partials        ?       0           

@lbenet
Copy link
Collaborator

lbenet commented May 26, 2023

Though not related to the main subject of this PR, few packages used (Healpix, IntervalArithmetic, StatsBase and TaylorIntegration) could (should?) be upgraded...

@PerezHz
Copy link
Owner Author

PerezHz commented May 26, 2023

Though not related to the main subject of this PR, few packages used (Healpix, IntervalArithmetic, StatsBase and TaylorIntegration) could (should?) be upgraded...

Just noticed PlanetaryEphemeris.jl v0.5.1 has not yet been released due to JuliaRegistries/General#84252 not being merged yet; this causes in turn that NEOs.jl environment cannot be resolved

@lbenet
Copy link
Collaborator

lbenet commented May 26, 2023

Just noticed PlanetaryEphemeris.jl v0.5.1 has not yet been released due to JuliaRegistries/General#84252 not being merged yet; this causes in turn that NEOs.jl environment cannot be resolved

There is a test failing in JuliaRegistries/General#84252, which may delay merging it.

Project.toml Outdated Show resolved Hide resolved
@PerezHz
Copy link
Owner Author

PerezHz commented May 27, 2023

There is a test failing in JuliaRegistries/General#84252, which may delay merging it.

I tried re-triggering JuliaRegistrator, but autoMerge failed again due to the process taking too long (again, probably due to precompilation during package loading)

@PerezHz
Copy link
Owner Author

PerezHz commented May 28, 2023

Though not related to the main subject of this PR, few packages used (Healpix, IntervalArithmetic, StatsBase and TaylorIntegration) could (should?) be upgraded...

I've now upgraded the dependencies compatibility requirements, including the update to PlanetaryEphemeris.jl v0.6.0 which has just been released.

I suggest to leave this as "0.3"; in includes all 0.3.x versions.

I also update this, thanks!

@PerezHz
Copy link
Owner Author

PerezHz commented May 28, 2023

We've got the green lights, so I'll go ahead and merge.

@PerezHz PerezHz merged commit 7387ccc into main May 28, 2023
@PerezHz PerezHz deleted the jp/gha branch May 28, 2023 10:50
@PerezHz
Copy link
Owner Author

PerezHz commented May 28, 2023

In the end, JuliaRegistrator returned an error regarding the NEOs.jl version stated as "0.3" in the Project.toml, which it interpreted as "0.3.0", so I pushed another commit onto main with the version "0.3.1".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI and CompatHelper GHAs
3 participants