Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPL's CNEOS Scout API #36

Merged
merged 4 commits into from
Feb 27, 2024
Merged

JPL's CNEOS Scout API #36

merged 4 commits into from
Feb 27, 2024

Conversation

LuEdRaMo
Copy link
Collaborator

No description provided.

@PerezHz
Copy link
Owner

PerezHz commented Feb 25, 2024

Hey, many thanks for this addition @LuEdRaMo! I think this change is pretty straight-forward so it LGTM. I would only point to tests failing on nightly, but I'd suggest to wait and see if those errors fade away, as is usually the case.

@LuEdRaMo
Copy link
Collaborator Author

I just bumped the patch version so this is ready. Once the errors with nightly are sorted out we can merge this. Btw, some tests fail because of Coveralls, do you know why?

@PerezHz
Copy link
Owner

PerezHz commented Feb 27, 2024

I just bumped the patch version so this is ready. Once the errors with nightly are sorted out we can merge this. Btw, some tests fail because of Coveralls, do you know why?

There's an ongoing issue with coveralls (see e.g. here), the workaround that I've found so far has been to avoid triggering CI simultaneously with push and pull_requests events. I can push that fix here, confirm that it works, and then merge.

@PerezHz
Copy link
Owner

PerezHz commented Feb 27, 2024

Tests are passing now, except nightly, but I think we can address those on another PR, so I'll go and merge this. Again, thanks a lot!

@PerezHz PerezHz merged commit 3b4ecc7 into main Feb 27, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants