Add support for config.rollup.mjs/ESM configs #179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup supports mjs/cjs/js extensions for the config:
So this adds support for that.
The change in cli.js searches for mjs/cjs with a fallback to .js (code copied from rollup)
The change in impl/ConfigLoader.js uses import when a file ends with mjs, instead of compiling and requiring.
A little extra work is needed for importing the mjs file on windows due to it needing urls and not paths: nodejs/node#34765
I would add tests but... it doesn't seem like the cli is tested. I could add an example project instead.