Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin error reporting is raw JSON instead of pretty #183

Closed
mizzao opened this issue Feb 22, 2021 · 7 comments
Closed

Plugin error reporting is raw JSON instead of pretty #183

mizzao opened this issue Feb 22, 2021 · 7 comments

Comments

@mizzao
Copy link

mizzao commented Feb 22, 2021

When I run Rollup, errors show up like this:

image

But with nollup they show up like this:

image

All errors appear to have this difference. Is there a simple way to use the nice formatting implied by the JSON instead of just outputting it raw? Perhaps I have misconfigured something, but if not happy to help improve the functionality here.

@PepsRyuu
Copy link
Owner

It's an error object I haven't taken into account. I can do something about that reasonably quickly. I'll get back to you on this. :)

@mizzao
Copy link
Author

mizzao commented Feb 23, 2021

Thanks, happy to help you test the implementation!

@PepsRyuu
Copy link
Owner

https://github.com/PepsRyuu/nollup/pull/185/files Seems to do the trick for TypeScript.

@PepsRyuu
Copy link
Owner

Released this initial version in 0.15.3

@mizzao
Copy link
Author

mizzao commented Feb 27, 2021 via email

@mizzao
Copy link
Author

mizzao commented Mar 2, 2021

Works great! This is what rollup vs nollup looks like now. The slight difference doesn't matter to me, but just posting in case you cared:

Rollup:

image

Nollup:

image

@PepsRyuu
Copy link
Owner

PepsRyuu commented Mar 2, 2021

I'm not too worried about it. Rollup's error reporting is fairly complicated, and its CLI is even doing stuff like overriding console.warn which I definitely don't want to do and can't do because of Nollup's middleware API. So there's going to be inconsistencies here no matter what, but an inconsistency here as far as I know is not very important. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants