Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safe feed time within the defined timeout #109

Merged
merged 1 commit into from
Feb 23, 2023
Merged

safe feed time within the defined timeout #109

merged 1 commit into from
Feb 23, 2023

Conversation

hsd-dev
Copy link
Contributor

@hsd-dev hsd-dev commented Feb 22, 2023

Related to #107

protocol error (120 invalid handle) is only sent by the sensor when we send a request with handle to it. This could be: Start, Stop, Configuration of Scan, Watchdog feeding (via http)

Nothing on the scan is changed – so only the watchdog feed is left. An indication for this is that the error messages are with a gap of 60 s (default timeout):

[/r2000_node INFO 1676938855.149217]: Device state changed to Running
# Here the driver is running. Watchdog is getting fed successfully for 5,2h. 
# Then suppose that one feeding came too late. This will cause the release of the handle by the R2000.
[/r2000_node INFO 1676957815.357771]: protocol error: 120 Invalid handle or no handle provided
# Feeding the watchdog is not possible anymore, because the used handle was released.
[/r2000_node INFO 1676957875.153960]: protocol error: 120 Invalid handle or no handle provided

The PR sets a “safe” feed within the defined timeout.

@hsd-dev
Copy link
Contributor Author

hsd-dev commented Feb 22, 2023

Still [WIP] because in case of

protocol error: 120 Invalid handle or no handle provided

the driver needs to detect a disconnect and then re-establish the connection

@hsd-dev hsd-dev changed the title [WIP] safe feed time within the defined timeout safe feed time within the defined timeout Feb 23, 2023
@ptruka ptruka merged commit b66d106 into main Feb 23, 2023
@hsd-dev hsd-dev deleted the safe_feed_time branch March 7, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants