Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA v0.40.0] Demo Improvements #1293

Merged
merged 26 commits into from
Jan 11, 2025
Merged

[QA v0.40.0] Demo Improvements #1293

merged 26 commits into from
Jan 11, 2025

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Jan 7, 2025 •
edited
Loading

Context:

Demo improvements encountered during the v0.40 quality assurance process.

Description of the Change:

A few things were adjusted in this PR,

  • Deprecated code update.
  • Seed nx.draw drawings since they are drawn with random vertex positions. This leads to false positives in our qml-diff-checker automated script.
  • Epoch count to reproduce features from an older version.
  • Add note to qrack.py about performance being dependent on the hardware used to execute the demo

@andrijapau andrijapau changed the title [QA v0.40.0] Fixes [QA v0.40.0] Source Code Improvements Jan 7, 2025
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1293
  • Deployment SHA: 0c03c43811c2316783a332567fafb118947a379a
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

@andrijapau andrijapau changed the title [QA v0.40.0] Source Code Improvements [QA v0.40.0] Demo Improvements Jan 8, 2025
@lillian542 lillian542 self-requested a review January 8, 2025 20:54
lillian542
lillian542 reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sold on the seeding thing, but I'm not vehemently opposed either. How much harder did these graphs make the demo diff check?

demonstrations/tutorial_equivariant_graph_embedding.py Show resolved Hide resolved
@andrijapau andrijapau merged commit 3a53c3a into dev Jan 11, 2025
10 checks passed
@andrijapau andrijapau deleted the dev-v0.40-fixes branch January 11, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qottmann Qottmann Qottmann left review comments

@JerryChen97 JerryChen97 JerryChen97 approved these changes

@lillian542 lillian542 lillian542 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrijapau @JerryChen97 @lillian542 @Qottmann @Alex-Preciado