-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove canonical URLs from demo metadata #1232
Remove canonical URLs from demo metadata #1232
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with TODOs ⭐ One question about version number
**Summary:** Fixes a merge conflict between `master` and `dev` introduced by #1232 (due to divergent `dateOfLastModification`). To reproduce this PR: 1. Run `git checkout dev`. 2. Run `git checkout -b merge-master-into-dev`. 3. Run `git merge master`. 4. Accept all incoming changes for merge conflicts on `dateOfLastModification`. **Relevant GHA Workflow Runs:** * https://github.com/PennyLaneAI/qml/actions/runs/11241666164 * https://github.com/PennyLaneAI/qml/actions/runs/11253088983 --------- Co-authored-by: David Wierichs <[email protected]> Co-authored-by: Korbinian Kottmann <[email protected]> Co-authored-by: Ivana Kurečić <[email protected]>
Title:
Remove the
canonicalURL
field from demo metadata.Summary:
This PR removes the
canonicalURL
field from existing demo metadata. ThecanonicalURL
field has been superseded by the (autogenerated)slug
field as of #1228.Relevant references:
None.
Possible Drawbacks:
None.
Related GitHub Issues:
None.
Detailed Changes:
$id
reference indemo.metadata.schema.0.1.3.json
.demo.metadata.schema.0.1.4.json
which removes thecanonicalURL
field.demonstrations_metadata.md
.canonicalURL
field from existing demo metadata (and adjusteddateOfLastModification
).update_metadata.py
script.Merge Checklist:
Verification:
The generated
metadata.json
file in the Glass Onion bucket no longer has anycanonicalURL
fields:metadata.json Snippet