Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QROM demo to master #1213

Merged
merged 20 commits into from
Sep 18, 2024
Merged

QROM demo to master #1213

merged 20 commits into from
Sep 18, 2024

Conversation

KetpuntoG
Copy link
Contributor

@KetpuntoG KetpuntoG commented Sep 5, 2024

New PR pointing to master
Some discussions were made in the other PR

Copy link

github-actions bot commented Sep 5, 2024

👋 Hey, looks like you've updated some demos!

🐘 Don't forget to update the dateOfLastModification in the associated metadata files so your changes are reflected in Glass Onion (search and recommendations).

Please hide this comment once the field(s) are updated. Thanks!

Copy link

github-actions bot commented Sep 5, 2024

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1213
  • Deployment SHA: 7170696bc0faa66c9e5538c4bd2d02e70434a837
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

Copy link
Contributor

@ixfoduap ixfoduap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions, should be good to go afterwards

demonstrations/tutorial_intro_qrom.py Outdated Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Outdated Show resolved Hide resolved
# Now we can check that all the outputs are as expected:

for i in range(8):
print(f"The bitstring stored in index {i} is: {circuit(i)}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently seeing strange outputs printed in the built version. Please revise

demonstrations/tutorial_intro_qrom.py Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Outdated Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Outdated Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Outdated Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Outdated Show resolved Hide resolved
KetpuntoG and others added 2 commits September 6, 2024 16:58
[skip ci]

Co-authored-by: ixfoduap <[email protected]>
@ikurecic
Copy link
Contributor

[sc-63852]

Copy link
Contributor

@ikurecic ikurecic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for sharing this, @KetpuntoG . I've updated some file names/paths and small typos in a commit, and I've now left you some comments and suggestions.
There are two small things I think you could add:

  • A clear reason why somebody should be interested in QROM right at the top of the Demo (not just a description of what you'll be doing in the Demo).
  • Some Demos in the relatedContent category of the metadata. Do you have any ideas about these?

Comment on lines 11 to 12
"dateOfPublication": "2024-09-09T00:00:00+00:00",
"dateOfLastModification": "2024-09-09T00:00:00+00:00",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tk

demonstrations/tutorial_intro_qrom.metadata.json Outdated Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Outdated Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Outdated Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Outdated Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Outdated Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Outdated Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Outdated Show resolved Hide resolved
demonstrations/tutorial_intro_qrom.py Show resolved Hide resolved
@ikurecic ikurecic merged commit c74fab7 into master Sep 18, 2024
10 checks passed
@ikurecic ikurecic deleted the qrom_demo_3 branch September 18, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants