-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QROM demo to master #1213
QROM demo to master #1213
Conversation
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
Thank you for opening this pull request. You can find the built site at this link. Deployment Info:
Note: It may take several minutes for updates to this pull request to be reflected on the deployed site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions, should be good to go afterwards
# Now we can check that all the outputs are as expected: | ||
|
||
for i in range(8): | ||
print(f"The bitstring stored in index {i} is: {circuit(i)}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm currently seeing strange outputs printed in the built version. Please revise
[skip ci] Co-authored-by: ixfoduap <[email protected]>
[sc-63852] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for sharing this, @KetpuntoG . I've updated some file names/paths and small typos in a commit, and I've now left you some comments and suggestions.
There are two small things I think you could add:
- A clear reason why somebody should be interested in QROM right at the top of the Demo (not just a description of what you'll be doing in the Demo).
- Some Demos in the relatedContent category of the metadata. Do you have any ideas about these?
"dateOfPublication": "2024-09-09T00:00:00+00:00", | ||
"dateOfLastModification": "2024-09-09T00:00:00+00:00", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tk
Co-authored-by: Ivana Kurečić <[email protected]>
New PR pointing to master
Some discussions were made in the other PR