Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo checks for v0.37 #1150

Merged
merged 9 commits into from
Jul 5, 2024
Merged

Demo checks for v0.37 #1150

merged 9 commits into from
Jul 5, 2024

Conversation

Shiro-Raven
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

👋 Hey, looks like you've updated some demos!

🐘 Don't forget to update the dateOfLastModification in the associated metadata files so your changes are reflected in Glass Onion (search and recommendations).

Please hide this comment once the field(s) are updated. Thanks!

@Shiro-Raven Shiro-Raven marked this pull request as ready for review July 5, 2024 14:59
@Shiro-Raven Shiro-Raven changed the title Ad/qa 0.37 Demo checks for v0.37 Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024 •
edited
Loading

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1150
  • Deployment SHA: 136c60c2b8cf84996026762f9ee67e04c2e84f40
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

lillian542
lillian542 reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the changes, and then of course the messaging about Lucy needs a quick update. Lmk when its ready for another look! :)

demonstrations/getting_started_with_hybrid_jobs.py Outdated Show resolved Hide resolved
lillian542
lillian542 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 🎉

@Shiro-Raven Shiro-Raven merged commit 62bff23 into dev Jul 5, 2024
10 checks passed
@Shiro-Raven Shiro-Raven deleted the ad/qa-0.37 branch July 5, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lillian542 lillian542 lillian542 approved these changes

@astralcai astralcai astralcai approved these changes

Assignees
No one assigned
Labels
merge-ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shiro-Raven @astralcai @lillian542