Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade qml.structure_constants to handle dense matrices #6861

Open
wants to merge 22 commits into
base: dla_lie_closure_dense
Choose a base branch
from

Conversation

Qottmann
Copy link
Contributor

@Qottmann Qottmann commented Jan 20, 2025

Integrate structure constants dense into [sc-81966]

Todo

  • update and unify documentation

@Qottmann Qottmann marked this pull request as ready for review January 22, 2025 16:13
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (2d784a3) to head (d7c93fa).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           dla_lie_closure_dense    #6861   +/-   ##
======================================================
  Coverage                  99.59%   99.59%           
======================================================
  Files                        479      479           
  Lines                      45369    45398   +29     
======================================================
+ Hits                       45187    45216   +29     
  Misses                       182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qottmann
Copy link
Contributor Author

Noticed that qml.math.diagonal dispatches to tf.linalg.diag_part instead of tf.keras.ops.diagonal , which to me seems like the natural fit when looking at other interfaces:

numpy.diagonal
torch.diagonal

I changed this, but might open pandora's box in the test suite 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants