-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgrade qml.structure_constants
to handle dense matrices
#6861
base: dla_lie_closure_dense
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dla_lie_closure_dense #6861 +/- ##
======================================================
Coverage 99.59% 99.59%
======================================================
Files 479 479
Lines 45369 45398 +29
======================================================
+ Hits 45187 45216 +29
Misses 182 182 ☔ View full report in Codecov by Sentry. |
Noticed that qml.math.diagonal dispatches to tf.linalg.diag_part instead of tf.keras.ops.diagonal , which to me seems like the natural fit when looking at other interfaces: I changed this, but might open pandora's box in the test suite 😬 |
Integrate structure constants dense into [sc-81966]
Todo