-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Capture] First PR for enabling dynamic decompositions with PLxPR
enabled
#6859
Open
PietropaoloFrisoni
wants to merge
33
commits into
master
Choose a base branch
from
cond_dynamic_decomp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+624
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. You may have forgotten to update the changelog!
|
PietropaoloFrisoni
changed the title
Exploring how to handle dynamic decompositions with Jan 21, 2025
qml.cond
in decompositions can be captured into PLxPRPLxPR
enabled
…o cond_dynamic_decomp
…o cond_dynamic_decomp
…o cond_dynamic_decomp
…o cond_dynamic_decomp
…o cond_dynamic_decomp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6859 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 478 478
Lines 45294 45342 +48
=======================================
+ Hits 45112 45160 +48
Misses 182 182 ☔ View full report in Codecov by Sentry. |
PietropaoloFrisoni
changed the title
Exploring how to handle dynamic decompositions with
[Capture] First PR for enabling dynamic decompositions with Jan 27, 2025
PLxPR
enabledPLxPR
enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The main purpose of this story is to implement a prototype for dynamic decompositions in PL with program capture enabled.
At this stage, we only focus on one-level dynamic decompositions (without implementing additional parameters that can be passed to the interpreter). The UI might change in the future.
Therefore, these are the main current limitations of the prototype introduced in this PR:
Description of the Change: As above.
Benefits: We can start capturing the decompositions dynamically with program capture enabled instead of simply returning the operators list at the end.
Possible Drawbacks: Still experimental. It shouldn't cause issues with the current program capture scaffolding.
Related GitHub Issues: None
Related Shortcut Stories: [sc-82690]