Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation qml.QSVT #6673

Merged
merged 22 commits into from
Dec 13, 2024
Merged

update documentation qml.QSVT #6673

merged 22 commits into from
Dec 13, 2024

Conversation

KetpuntoG
Copy link
Contributor

Context:

This PR update the documentation of QSVT to clearly show coding examples

[sc-76733]

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.62%. Comparing base (0aa4738) to head (5a89880).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #6673    +/-   ##
========================================
  Coverage   99.61%   99.62%            
========================================
  Files         473      474     +1     
  Lines       44355    44617   +262     
========================================
+ Hits        44186    44448   +262     
  Misses        169      169            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soranjh soranjh requested review from soranjh and DSGuala December 10, 2024 20:01
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
soranjh and others added 2 commits December 10, 2024 16:49
Copy link
Contributor Author

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go! Thanks for working on it
As I created the PR I cannot approve. Feel free to do it for me 🚀

pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Show resolved Hide resolved
Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left some comments to help polish 👍

pennylane/templates/subroutines/qsvt.py Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/qsvt.py Outdated Show resolved Hide resolved
@soranjh soranjh enabled auto-merge (squash) December 13, 2024 21:42
@soranjh soranjh merged commit 2bb567a into master Dec 13, 2024
46 checks passed
@soranjh soranjh deleted the docs_QSVT branch December 13, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants