Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Capture] JIT entire workflows with default qubit #6655

Merged
merged 65 commits into from
Dec 5, 2024

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Nov 29, 2024

Context:

When messing around with #6596, I realized we weren't able to jit the full workflow even though the device execution itself can still be jitted. I needed to register the mlir lowering to just be the lowering of the implementation function.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-79566]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (ce9e5ff) to head (d9480e4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6655   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         467      467           
  Lines       44166    44170    +4     
=======================================
+ Hits        44010    44014    +4     
  Misses        156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from native-dq-execution to master December 5, 2024 15:30
@mudit2812 mudit2812 self-requested a review December 5, 2024 15:38
@mudit2812 mudit2812 requested a review from lillian542 December 5, 2024 16:16
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
@albi3ro albi3ro enabled auto-merge (squash) December 5, 2024 19:26
@albi3ro albi3ro merged commit 4fbabae into master Dec 5, 2024
46 checks passed
@albi3ro albi3ro deleted the capture-execution-jit branch December 5, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants