Autograph with make plxpr #6645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into autograph_ctrl_flow
lillian542
commented
Dec 4, 2024
…nnylane into autograph_with_make_plxpr
JerryChen97
approved these changes
Dec 4, 2024
Co-authored-by: Yushao Chen (Jerry) <[email protected]>
albi3ro
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We have autograph functionality that allows us to convert user code with Python control flow to something PL-compatible, but it's not integrated in
make_plxpr.Also something happened with the changelog organization and things ended up under Qubit Mixed Device API and Dynamic Lie algebra that didn't belong there, so I shuffled things around.
Description of the Change:
We add this to
make_plxpr. By default, autograph will be run on all functions.A few tests that were using
mocker.spyhad to be updated, because nowmake_jaxpris called with an 'unknown' argument (the function that comes out ofrun_autograph), so we can't spy on its calls the same way we were.[sc-71823]