-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize execution interfaces by adding internal Enum
object
#6643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster" This reverts commit f459d64.
andrijapau
changed the title
[WIP] Add internal
Add internal Dec 4, 2024
Enum
to standarize execution interfacesEnum
to standarize execution interfaces
albi3ro
reviewed
Dec 4, 2024
albi3ro
reviewed
Dec 4, 2024
…al_interface_name
albi3ro
reviewed
Dec 5, 2024
I believe this now also satisfies [sc-51194] |
albi3ro
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
lillian542
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So neat and tidy! 🧹
andrijapau
changed the title
Add internal
Standardize execution interfaces by adding internal Dec 5, 2024
Enum
to standarize execution interfacesEnum
object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This is a follow-up to #6649.
The purpose of this PR is to standardize how the
interface
value is handled, preventing it from being remapped multiple times during execution. Users should provide their preferred interface, which will be mapped directly to a canonical value for consistent use. If the interface is set to "auto", it will be inferred from the data type and converted into a supported canonical interface. This inferred interface value will then be used to configure the execution later down the pipeline.Description of the Change:
qnode.py
andexecution.py
to use a new canonical interfaceEnum
.interface
to be a string in parts of the code where it is now represented as an enum value.interface=None
. Instead, the default interface is now explicitly set tonumpy
.execution config
to store only the canonical interface value.Benefits:
interface
value is handled during execution.Possible Drawbacks: None identified.
[sc-73432]
[sc-79735]