add sampling for qubit_mixed module
#6639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryChen97
changed the title
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Astral Cai <[email protected]>
Co-authored-by: Astral Cai <[email protected]>
…neAI/pennylane into add-qubit_mixed/sampling
JerryChen97
removed
the
do not merge ⚠️
mudit2812
reviewed
Dec 3, 2024
mudit2812
reviewed
Dec 3, 2024
mudit2812
reviewed
Dec 3, 2024
mudit2812
reviewed
Dec 3, 2024
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
astralcai
reviewed
Dec 3, 2024
JerryChen97
commented
Dec 3, 2024
astralcai
approved these changes
Dec 4, 2024
mudit2812
reviewed
Dec 4, 2024
Co-authored-by: Mudit Pandey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
In the new API interface of
default_mixed, the submodulesamplingis our final blocker to the remaining functionalities.It provides three important helpers,
sample_probs,sample_stateandmeasure_with_samples.Description of the Change:
Added the implementation of
sampling.Added the tests of
sampling; note that compared with the qutrit counterpart, here the tests are highly simplified, to avoid unnecessary re-work in the future when we come back to improve the test suites for these two modulesBenefits:
Remove the blockers for the following-ups.
Drastically simplify the sampling code by reusing qubit src code
Possible Drawbacks:
There is an introduced dependency on
qubit.sample_probsRelated GitHub Issues:
[sc-79095]