Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating default.tensor to the latest quimb version #6630

Merged
merged 12 commits into from
Dec 19, 2024

Conversation

PietropaoloFrisoni
Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni commented Nov 25, 2024

Context: With the new version (1.9.0) of quimb, released on 2024-11-19, DefaultTensor no longer works.

This seems to depend on the fact that the local_expectation method for MPS quantum circuits no longer works if dtype is specified.

See this discussion in quimb for details.

Now that quimb 1.10 has been released, PennyLane is compatible with the latest quimb again.

Description of the Change: We just unpin the quimb version in the CI.

Benefits: PennyLane is compatible again with the latest quimb, and we'll know if something is not working.

Possible Drawbacks: None.

Related GitHub Issues: None.

Related ShortCut Stories: [sc-78734]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@PietropaoloFrisoni PietropaoloFrisoni marked this pull request as ready for review December 13, 2024 12:46
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (3ff71de) to head (374d744).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6630   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files         478      478           
  Lines       45045    45045           
=======================================
  Hits        44868    44868           
  Misses        177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrijapau andrijapau self-requested a review December 19, 2024 16:50
Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! @PietropaoloFrisoni

@PietropaoloFrisoni PietropaoloFrisoni enabled auto-merge (squash) December 19, 2024 17:00
@PietropaoloFrisoni PietropaoloFrisoni merged commit e1566e5 into master Dec 19, 2024
45 checks passed
@PietropaoloFrisoni PietropaoloFrisoni deleted the updating_default_tensor branch December 19, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants