Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move _cache_transform to its own file in qml.workflow #6624

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Nov 21, 2024

Context:

Introduces a new file _cache_transform.py in qml.workflow to house the private _cache_transform helper. Previously it lived in execution.py despite having its own unit test file workflow/test_cache_transform.py.

Also, update file name: resolve_diff_method.py_resolve_diff_method.py as I should have done earlier. 😄

Benefits: Code consistency and clean-up

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@andrijapau andrijapau requested a review from albi3ro November 21, 2024 14:50
@andrijapau andrijapau changed the title Move _cache_transform to its own file Move _cache_transform to its own file in qml.workflow Nov 21, 2024
Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (76f9d7c) to head (183635d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6624   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files         451      452    +1     
  Lines       42293    42323   +30     
=======================================
+ Hits        42062    42092   +30     
  Misses        231      231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@andrijapau andrijapau enabled auto-merge (squash) November 21, 2024 16:24
@andrijapau andrijapau merged commit 96d2587 into master Nov 21, 2024
45 checks passed
@andrijapau andrijapau deleted the move-cache-transform branch November 21, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants