-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move _cache_transform
to its own file in qml.workflow
#6624
Conversation
Hello. You may have forgotten to update the changelog!
|
_cache_transform
to its own file_cache_transform
to its own file in qml.workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Yushao Chen (Jerry) <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6624 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 451 452 +1
Lines 42293 42323 +30
=======================================
+ Hits 42062 42092 +30
Misses 231 231 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Context:
Introduces a new file
_cache_transform.py
inqml.workflow
to house the private_cache_transform
helper. Previously it lived inexecution.py
despite having its own unit test fileworkflow/test_cache_transform.py
.Also, update file name:
resolve_diff_method.py
→_resolve_diff_method.py
as I should have done earlier. 😄Benefits: Code consistency and clean-up