-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simulate of analytic case for DefaultMixedNewAPI #6618
Conversation
Mimicing the qutrit mixed one.
Co-authored-by: Astral Cai <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Astral Cai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Astral Cai <[email protected]>
Co-authored-by: Astral Cai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few comments about tidying up the tests a little bit, but looking good 🚀
…hub.com/PennyLaneAI/pennylane into add-analytic-simulate-for-mixed-new-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
Context:
The implementation of method
simulate
is the most important one under the architecture of new API standard. The point ofsimulate
, is basically abstract both the analytic version (controlled byshots=None
, or infinite shots in a fancier way) and the MC version (finite shots). Meanwhile, the functionality of such method should not truly depend on our details of qml implementationi; they better only rely on either the fundamental computation libs, e.g. math lib and qnp, or the most essential infras, e.g. Tape/Scripts and Operations.Description of the Change:
qml.devices.qubit_mixed.simulate
simulate
Benefits:
Implementation of this submodule is necessary to several other PR's
Possible Drawbacks:
finite-shot branch not yet implemneted
Related GitHub Issues:
[sc-73320]