-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce passing by keyword argument in QNode
and qml.execute
#6610
Conversation
QNode
and qml.execute
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6610 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 455 455
Lines 42821 42820 -1
==========================================
- Hits 42672 42671 -1
Misses 149 149 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Nice clean-up 🚀
I'm excited to find out how many tests will need to be updated 😅 |
exactly zero 😆 |
Context:
Passing too many arguments positionally is error prone. It can be difficult to remember what the proper order of the arguements is, and it can be easy to reorder keyword arguments.
Description of the Change:
Start mandating that various keyword arguments are passed as keyword arguments in
QNode
andqml.execute
Benefits:
We forbid entire classes of mistakes.
Possible Drawbacks:
Related GitHub Issues: