Make qml.math.jax_argnums_to_tape_trainable private
#6609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Nov 19, 2024
…om/PennyLaneAI/pennylane into move-jax-argnums-to-tape-trainable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6609 +/- ##
==========================================
- Coverage 99.45% 99.45% -0.01%
==========================================
Files 450 450
Lines 42088 42087 -1
==========================================
- Hits 41857 41856 -1
Misses 231 231 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
dwierichs
approved these changes
Nov 20, 2024
PietropaoloFrisoni
approved these changes
Nov 20, 2024
Co-authored-by: Pietropaolo Frisoni <[email protected]> Co-authored-by: David Wierichs <[email protected]>
astralcai
pushed a commit
that referenced
this pull request
Nov 20, 2024
**Context:** The `math` module should only depend on autoray, numpy, and all the various ML frameworks. We have one method though, `jax_argnums_to_tape_trainable`, that introduces a qnode dependency into the math module. This function is only used in `transform_program.py` as an implementation detail. **Description of the Change:** Moves `jax_argnums_to_tape_trainable` to `transform_program.py` and makes it private. **Benefits:** Cleaner dependency tree in pennylane. **Possible Drawbacks:** It could technically be considered a breaking change, but I really don't think such a function needs to be part of the public `math` interface. If we really wanted to make it part of the official `math` interface, we should have at least tested it. **Related GitHub Issues:** --------- Co-authored-by: Pietropaolo Frisoni <[email protected]> Co-authored-by: David Wierichs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The
mathmodule should only depend on autoray, numpy, and all the various ML frameworks.We have one method though,
jax_argnums_to_tape_trainable, that introduces a qnode dependency into the math module. This function is only used intransform_program.pyas an implementation detail.Description of the Change:
Moves
jax_argnums_to_tape_trainabletotransform_program.pyand makes it private.Benefits:
Cleaner dependency tree in pennylane.
Possible Drawbacks:
It could technically be considered a breaking change, but I really don't think such a function needs to be part of the public
mathinterface. If we really wanted to make it part of the officialmathinterface, we should have at least tested it.Related GitHub Issues: