[BugFix] KeyError when running QNode(qfun, dev)(graph) with graph an instance of networkx Graph object
#6600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6600 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 450 450
Lines 42088 42088
=======================================
Hits 41857 41857
Misses 231 231 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
astralcai
approved these changes
Nov 19, 2024
JerryChen97
approved these changes
Nov 19, 2024
astralcai
pushed a commit
that referenced
this pull request
Nov 20, 2024
… an instance of `networkx` Graph object (#6600) **Context:** Issue #6585 indicates that we don't currently allow arguments with types defined in libraries not listed in the supported interfaces. In #6225, the convention of treating internally as `interface=None` parameters of the `numpy` interface has been introduced. The idea of this PR is to allow non-trainable `qnode` inputs to "just work" as arguments, without any special consideration or treatment. We want to rely on the default `numpy` interface for libraries we know nothing about. **Description of the Change:** By default, we set `None` as the value of the interface if the latter is not found in the list of supported interfaces. According to the convention introduced in #6225, this should automatically map the interface to `numpy`. **Benefits:** Now the `qnode` accepts arguments with types defined in libraries that are not necessarily in the list of supported interfaces, such as the `Graph` class defined in `networkx`. **Possible Drawbacks:** None that I can think of. **Related GitHub Issues:** #6585 **Related Shortcut Stories:** [sc-78344] --------- Co-authored-by: Christina Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Issue #6585 indicates that we don't currently allow arguments with types defined in libraries not listed in the supported interfaces.
In #6225, the convention of treating internally as
interface=Noneparameters of thenumpyinterface has been introduced.The idea of this PR is to allow non-trainable
qnodeinputs to "just work" as arguments, without any special consideration or treatment. We want to rely on the defaultnumpyinterface for libraries we know nothing about.Description of the Change: By default, we set
Noneas the value of the interface if the latter is not found in the list of supported interfaces. According to the convention introduced in #6225, this should automatically map the interface tonumpy.Benefits: Now the
qnodeaccepts arguments with types defined in libraries that are not necessarily in the list of supported interfaces, such as theGraphclass defined innetworkx.Possible Drawbacks: None that I can think of.
Related GitHub Issues: #6585
Related Shortcut Stories: [sc-78344]