Remove top-level access to Device, QubitDevice and QutritDevice
#6537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6c8ac27.
…tDevice`-and-`QutritDevice`
JerryChen97
added
the
do not merge ⚠️
|
I guess my autoblack over the init files messed up something. Do not merge before fix |
…tDevice`-and-`QutritDevice`
…tDevice`-and-`QutritDevice`
JerryChen97
commented
Nov 8, 2024
…tDevice`-and-`QutritDevice`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6537 +/- ##
==========================================
- Coverage 99.30% 99.29% -0.01%
==========================================
Files 454 454
Lines 43269 43267 -2
==========================================
- Hits 42967 42964 -3
- Misses 302 303 +1 ☔ View full report in Codecov by Sentry. |
JerryChen97
added
merge-ready ✔️
astralcai
reviewed
Nov 8, 2024
There was a problem hiding this comment.
Many of our type hints and documentation are outdated, we shouldn't just replace all mentions of pennylane.Device with pennylane.devices.LegacyDevice because that would be inaccurate. Unless something is exclusively referring to a LegacyDevice (there shouldn't be many of them anymore), we should use pennylane.devices.Device.
This reverts commit e578ba8.
…tDevice`-and-`QutritDevice`
albi3ro
reviewed
Nov 12, 2024
albi3ro
reviewed
Nov 12, 2024
albi3ro
reviewed
Nov 12, 2024
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
…`QutritDevice`' of https://github.com/PennyLaneAI/pennylane into Remove-top-level-access-to-`Device`,-`QubitDevice`-and-`QutritDevice`
albi3ro
reviewed
Nov 12, 2024
albi3ro
reviewed
Nov 12, 2024
albi3ro
reviewed
Nov 12, 2024
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
…tDevice`-and-`QutritDevice`
lillian542
approved these changes
Nov 13, 2024
…tDevice`-and-`QutritDevice`
JerryChen97
deleted the
Remove-top-level-access-to-`Device`,-`QubitDevice`-and-`QutritDevice`
branch
5 tasks
JerryChen97
added a commit
to PennyLaneAI/qml
that referenced
this pull request
Dec 5, 2024
**Title:** Remove QubitDevice warnings, which will be removed in the 0.40PL **Summary:** as title **Relevant references:** #PennyLaneAI/pennylane#6537 **Possible Drawbacks:** None **Related GitHub Issues:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
In previous cycle the access to the three legacy devices has already been deprecated:
Here we would like to remove them.
Description of the Change:
qml.Device,qml.QubitDeviceandqml.QutritDeviceentirely from pennylane repoBenefits:
Fin the depr cycle
Possible Drawbacks:
Downstreaming incompatibility. Would be fixed in the corresponding pr's
Related GitHub Issues:
Related Shortcut Stories:
[sc-77502]