Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qml.broadcast template #6527

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Remove qml.broadcast template #6527

merged 7 commits into from
Nov 12, 2024

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Nov 5, 2024

Context:

Completing the deprecation cycle of qml.broadcast.

Description of the Change:

  1. Update deprecations.rst
  2. Update changelog-dev.md
  3. Remove all deprecated source code

Found references in Catalyst: PennyLaneAI/catalyst#1290
No references found in Lightning and QML.

[sc-77484]

@andrijapau andrijapau changed the title Removal of qml.broadcast template Remove qml.broadcast template Nov 6, 2024
@andrijapau andrijapau requested a review from lillian542 November 7, 2024 14:18
@andrijapau andrijapau marked this pull request as ready for review November 7, 2024 15:48
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a from .broadcast import * in templates/__init__.py that will need to go as well, and a section in the Templates documentation (see this page)

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.29%. Comparing base (297e573) to head (478abe0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6527      +/-   ##
==========================================
- Coverage   99.29%   99.29%   -0.01%     
==========================================
  Files         457      456       -1     
  Lines       43413    43358      -55     
==========================================
- Hits        43109    43054      -55     
  Misses        304      304              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CodeCov complaint looks like the recurring one since the legacy opmath deprecation - hopefully that will stop showing up once the removal is merged. Not sure what's going on with the dependency deps upload, but it looks unrelated.

Seems good to me, apart from the weird CI issues 🙈

@mudit2812
Copy link
Contributor

Not sure what's going on with the dependency deps upload

This was fixed in #6556

@andrijapau andrijapau added merge-ready ✔️ All tests pass and the PR is ready to be merged. do not merge ⚠️ Do not merge the pull request until this label is removed and removed merge-ready ✔️ All tests pass and the PR is ready to be merged. labels Nov 8, 2024
@andrijapau andrijapau removed the do not merge ⚠️ Do not merge the pull request until this label is removed label Nov 12, 2024
@andrijapau andrijapau merged commit e27f881 into master Nov 12, 2024
46 checks passed
@andrijapau andrijapau deleted the remove-qml-broadcast branch November 12, 2024 18:58
andrijapau added a commit to PennyLaneAI/catalyst that referenced this pull request Nov 12, 2024
**Context:**

Completing the deprecation cycle of `qml.broadcast` (see
PennyLaneAI/pennylane#6527)

**Description of the Change:**

Removed all references to the deprecated source code.

[sc-77484]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants