Fix Identity.__repr__ bug
#6506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
JerryChen97
requested changes
Nov 4, 2024
JerryChen97
approved these changes
Nov 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6506 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 455 456 +1
Lines 43193 43258 +65
=======================================
+ Hits 42909 42974 +65
Misses 284 284 ☔ View full report in Codecov by Sentry. |
mudit2812
approved these changes
Nov 4, 2024
Co-authored-by: Mudit Pandey <[email protected]>
andrijapau
added
the
merge-ready ✔️
mudit2812
added a commit
that referenced
this pull request
Nov 11, 2024
**Context:** Prior to this fix, the `repr` for `Identity` was incorrectly indexing `self.wires` at zero. This returned incorrect string representations. ```python >>> repr(qml.I([0, 1, 2, 3]) 'I(0)' ``` This was potentially not caught as the `__repr__` method was not being tested. After this fix, the entire `self.wires` attribute is being processed. This returns the intended string representations of the operator, ```python >>> repr(qml.I([0, 1, 'a', 3]) 'I([0,1,'a',3])' >>> repr(qml.I([0]) 'I(0)' >>> repr(qml.I()) 'I()' ``` **Description of the Change:** 1. Corrected the handling of `self.wires` in `Identity.__repr__`. 2. Added a test to `test_identity.py` to make sure the string representation is accurate. **Benefits:** Code accuracy and clarity. **Possible Drawbacks:** N/A Fixes [sc-77328] --------- Co-authored-by: Mudit Pandey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Prior to this fix, the
reprforIdentitywas incorrectly indexingself.wiresat zero. This returned incorrect string representations.This was potentially not caught as the
__repr__method was not being tested.After this fix, the entire
self.wiresattribute is being processed. This returns the intended string representations of the operator,Description of the Change:
self.wiresinIdentity.__repr__.test_identity.pyto make sure the string representation is accurate.Benefits: Code accuracy and clarity.
Possible Drawbacks: N/A
Fixes [sc-77328]