-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Capture] add plxpr_to_tape
function
#6343
Conversation
…AI/pennylane into plxpr-interpreter-base
Co-authored-by: David Wierichs <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6343 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 468 469 +1
Lines 44149 44233 +84
=======================================
+ Hits 43979 44064 +85
+ Misses 170 169 -1 ☔ View full report in Codecov by Sentry. |
convert_to_tape
functionplxpr_to_tape
function
Leaving this warning from the docs build here:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: Pietropaolo Frisoni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very minor comment/question, looks good to me!
**Context:** With the addition of the `PlxprInterpreter` class, we can now easily set up tools for converting from plxpr to something else. For device execution, we need to be able to collect all the ops in a jaxpr in order to apply the adjoint or control transform primitivies. So I'm adding this in now. **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-74926] --------- Co-authored-by: David Wierichs <[email protected]> Co-authored-by: Pietropaolo Frisoni <[email protected]>
Context:
With the addition of the
PlxprInterpreter
class, we can now easily set up tools for converting from plxpr to something else.For device execution, we need to be able to collect all the ops in a jaxpr in order to apply the adjoint or control transform primitivies. So I'm adding this in now.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-74926]