Expand documentation for qml.from_qiskit() (abandoned)
#5259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
|
[sc-57149] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.35.0-rc0 #5259 +/- ##
==============================================
Coverage ? 99.65%
==============================================
Files ? 399
Lines ? 36601
Branches ? 0
==============================================
Hits ? 36473
Misses ? 128
Partials ? 0 ☔ View full report in Codecov by Sentry. |
**Must not be merged before the creation of the release candidate branch for 0.35.0** Updates PennyLane as we're entering a new development version (release of v0.35.0 coming up): - Create changelog-dev.md - Add changelog-dev.md to release-notes.md - Increments the version number to v0.36.0-dev ``` rc master | | | - (**THIS PR**)add changelog-dev.md, add changelog-dev reference to release_notes.md, bump version to 0.36.0-dev | / | / | / | / |/ - rename changelog-dev.md to changelog-0.35.0.md, change changelog-dev reference to changelog-0.35 reference in release_notes.md, move "current release" label from changelog-0.34 to changelog-0.35, change version from 0.35.0-dev to 0.25.0 | | ``` --------- Co-authored-by: Matthew Silverman <[email protected]>
trbromley
reviewed
Feb 26, 2024
#5246) fix for #5245 [sc-57300] --------- Co-authored-by: Matthew Silverman <[email protected]>
**Context:** PRs on forks fail the docs CI when trying to upload freeze changes, so I'd like to just skip that part if the PR is from a fork. **Description of the Change:** Skip those steps if on a fork, as described [here](https://github.com/orgs/community/discussions/25217). **Benefits:** External contributor PRs won't fail unexpectedly **Possible Drawbacks:** N/A - it will run often enough by us internally that the docs freeze file will be kept up-to-date regardless **Related GitHub Issues:** - Example failure: https://github.com/PennyLaneAI/pennylane/actions/runs/8039250831/job/21956066233?pr=5256 - Confirmed it skips on forks: https://github.com/PennyLaneAI/pennylane/actions/runs/8071064111/job/22049837508?pr=5272
Automatic sync from the release candidate to master during a feature freeze. --------- Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: Nathan Killoran <[email protected]> Co-authored-by: Matthew Silverman <[email protected]> Co-authored-by: Astral Cai <[email protected]> Co-authored-by: Mikhail Andrenkov <[email protected]> Co-authored-by: GitHub Actions Bot <> Co-authored-by: lillian542 <[email protected]>
Co-authored-by: Thomas R. Bromley <[email protected]>
Mandrenkov
changed the title
qml.from_qiskit()
|
Thanks for the review, @trbromley! I've replied to your suggestions and made some additional changes. |
trbromley
reviewed
Feb 28, 2024
trbromley
reviewed
Feb 28, 2024
trbromley
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Thanks @Mandrenkov! Approved once we resolve the remaining comments.
|
Any worries about 7d05c63? We could always create a new PR since the changes here are pretty localized, if we're worried about a polluted branch. |
Co-authored-by: Thomas R. Bromley <[email protected]>
|
Thanks for taking another look, @trbromley!
Yeah, it may be cleaner to just make a new branch and apply the changes by hand. I'll open up a new PR and link it here. |
Mandrenkov
added a commit
that referenced
this pull request
Feb 28, 2024
Mandrenkov
changed the title
qml.from_qiskit()qml.from_qiskit() (abandoned)
|
Closed in favour of #5279. |
Mandrenkov
added a commit
that referenced
this pull request
Feb 28, 2024
**Context:** The documentation for `qml.from_qiskit()` is lacking in both breadth, depth, and examples. Note that this PR forks #5259 due to 7d05c63. **Description of the Change:** * Expanded the `qml.from_qiskit()` docstring. * Applied analagous style changes to the `qml.from_qiskit_op()` docstring. * Added a reference target `mid_circuit_measurements`. **Benefits:** * Users can use the `qml.from_qiskit()` function with more ease and confidence. **Possible Drawbacks:** None. **Related GitHub Issues:** None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional documentation and examples to the
qml.from_qiskit()function.