-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix premature session closure error #608
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #608 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 868 869 +1
=========================================
+ Hits 868 869 +1 ☔ View full report in Codecov by Sentry. |
Hi @takh04, thanks for opening this PR. The CI is failing right now because of some codefactor issue, likely because we updated our standards and this code hasn't been updated in a while. We can fix this just by appending Additionally, please write a changelog entry in |
Hi @austingmhuang, thanks for the reply! I have appended too-many-positional-arguments and added changelog entry! |
This issue shows pennylane-qiskit session closes prematurely. Simply adding _if self.session is None: fixes the problem. The fix is tested on both IBM fake device and real devices.