Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session doc changes #594

Merged
merged 29 commits into from
Oct 31, 2024
Merged

Session doc changes #594

merged 29 commits into from
Oct 31, 2024

Conversation

austingmhuang
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e684a34) to head (030d9c1).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #594   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          868       868           
=========================================
  Hits           868       868

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mudit2812
mudit2812 reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a changelog entry 🙏

soranjh
soranjh requested changes Oct 31, 2024
View reviewed changes
pennylane_qiskit/qiskit_device.py Outdated Show resolved Hide resolved
pennylane_qiskit/qiskit_device.py Outdated Show resolved Hide resolved
pennylane_qiskit/qiskit_device.py Outdated Show resolved Hide resolved
soranjh
soranjh reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @austingmhuang, added some suggestions to make the the message clear and brief.

@austingmhuang austingmhuang merged commit a90a1d9 into master Oct 31, 2024
10 checks passed
@austingmhuang austingmhuang deleted the session_docs branch October 31, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soranjh soranjh soranjh approved these changes

@mudit2812 mudit2812 mudit2812 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@austingmhuang @mudit2812 @soranjh