-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin Qiskit where relevant #508
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## compatibility #508 +/- ##
===============================================
Coverage 100.00% 100.00%
===============================================
Files 7 7
Lines 556 556
===============================================
Hits 556 556 ☔ View full report in Codecov by Sentry. |
[sc-57197] |
astralcai
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸
mudit2812
approved these changes
Apr 5, 2024
lillian542
added a commit
that referenced
this pull request
Apr 10, 2024
* remove deprecated installation syntax from test yaml * run all the test vs Qiskit 1.0 * update to only raise error for BasicAer * add missing import * reorganize test parameterization for 1.0 * remove unused import * add a BasicSimulator device * import BasicSimulatorDevice * update combinations of test devices and backends * update devices and backends in integration tests * update tests for incompatible devices and versions * update QiskitDevice tests to use IBMQ instead of BasicAer * tweak QiskitDevice for compatibility with BasicSimulator * fix bad relative import path * skip devices in conftest with incompatible provider-backend combinations * qasm_simulator is just qasm_simulator for old qiskit too now * more fixes for combinations of providers and backends * move import to top level * update to supported backends in test_qiskit_device.py * correct Regex pattern for error test * update providers and backends in test_integration.py * trigger ci * use provider that doesn't requre token * run device integration tests with 1.0 * correct backend for 1.0 device integration tests * upload 1.0 test results to codecov * add IBMQ tests with 1.0 * add basicsim device to documentation * update install instructions * update changelog * update basicsim documentation * update docstring for basicsim * cutoff for basicaer is 0.46 instead of 0.45.3 * remove whitespace * black formatting * indicate partial version number * small docs update * Apply suggestions from code review Co-authored-by: Thomas R. Bromley <[email protected]> * rearrange order of device cards on docs page * docs updates * Update doc/devices/basicsim.rst Co-authored-by: Thomas R. Bromley <[email protected]> * add reference * correct reference * maybe it doesn't like underscores? * update reference * update refs * add custom analytic not supported msg for BasicProvider device * update warning * remove unused import * remove kwarg section of basic_simulator docstring * trigger ci * Unpin Qiskit where relevant (#508) * update to use requirements-ci and requirements-ci-legacy * unpin qiskit-ibm-runtime * add explicit qiskit-ibm-runtime requirement * unpin in upload yaml * update changelog * add codecov token for 1.0 tests * add codecov token for 1.0 tests one more place --------- Co-authored-by: Thomas R. Bromley <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements-ci.txt
files so that there is a legacy and a standard version, and the standard versions tests vs Qiskit 1.0.qiskit
andqiskit-ibm-runtime
where relevantSee the
pip freeze
print-out in theInstall Plugin
section of the tests to confirm that they are run with the expected version numbers.