Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with 1.0 for devices #493
Compatibility with 1.0 for devices #493
Changes from 51 commits
6f2c067
39d1c37
ffc33e3
4629ac4
0c257c5
39f040b
281088e
c6328eb
72163a6
75447df
0ee569b
714f263
7a9f31e
8cae9f9
9f36d27
ee4a0cd
79a2880
4d3996a
8435386
9989ad3
0065480
9032d2b
652adfb
3268f65
4747883
8c2c528
ec6da21
61ad265
aae375e
767dbf4
c5c0886
a793665
452114c
1ac068a
24a8957
e545e4c
77aabab
754eee4
57736a4
bfcd346
fe0dc6d
c75ef36
36855c0
3058267
655166a
e6a9180
ec65874
0125bab
e1664eb
094afba
05735df
1db98aa
e0f8af5
647d64c
ef9c832
1feb916
ec9bae5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what we will do here regarding this announcement 🤔 We might need to migrate to using the local integration tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these remote tests being run in the plugin test matrix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are running in the plugin matrix. And yes, we've started seeing warnings about that when running the tests.
Probably we will want to change our default backend for devices that currently use the
ibmq_qasm_simulator
to be theaer_simulator
instead, since that's one of their recommended options in their migration documentation.For our test, I think almost everything using the
ibmq_qasm_simulator
can also just be replaced with theaer_simulator
for now. The fake providers and backends sound nice long-term, but just usingaer_simulator
should be pretty quick fix to keep our tests working in the meantime.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would the other option be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently there is no other option here, but they add/change backends sometimes. Our default format for the device
init
functions so far has been that we don't worry about that - users can check backend options and pass what they want from the list of available backends. The list of available backends is in this case is["basic_simulator"]
. Maybe this should move tokwargs
though? It's just here to match the other device signatures right now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I'd be a bit confused about the backend option. If I put
backend='aer_simulator'
, things wouldn't work?I'm happy to leave this in for now though, as the precedent is already set in other devices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these the only two
kwargs
one might want to use?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but we generally haven't documented allowed kwargs, because they are really determined by Qiskit, are backend-dependent, and we just pass them through. We don't have a complete list of options. I'll go over them and make sure we aren't missing any PennyLane specific ones though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't come up with any other PennyLane kwargs we would want to include here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I'm thinking we remove these two, since I don't understand how or why I'd want to use them 😆