Add exact tensor network C++ backend to LT #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
…set before quantum state creation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #977 +/- ##
==========================================
- Coverage 95.84% 92.01% -3.84%
==========================================
Files 230 113 -117
Lines 38823 17017 -21806
==========================================
- Hits 37211 15658 -21553
+ Misses 1612 1359 -253 ☔ View full report in Codecov by Sentry. |
multiphaseCFD
added
the
ci:use-gpu-runner
multiphaseCFD
removed
the
ci:use-gpu-runner
### Before submitting
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [ ] Ensure that the test suite passes, by running `make test`.
- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [ ] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
Lightning.tensor device adding TN backend
**Description of the Change:**
* Unit tests for gate support
* Unit tests for measurements
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
[sc-77835]
---------
Co-authored-by: Shuli Shu <[email protected]>
josephleekl
reviewed
Dec 3, 2024
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCudaBase.hpp
Show resolved
Hide resolved
|
do we want to change this method string to |
|
Thanks for the awesome addition of exact tensor network! @multiphaseCFD Just added some questions/comments, happy to approve once answered! |
multiphaseCFD
added
ci:use-gpu-runner
multiphaseCFD
requested review from
josephleekl
and removed request for
josephleekl
LuisAlfredoNu
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Thank you @multiphaseCFD!
Nice code. Just a couple of comments but feel free to ignore them if you need.
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/ExactTNCuda.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCuda.hpp
Outdated
Show resolved
Hide resolved
josephleekl
approved these changes
Dec 5, 2024
maliasadi
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
[sc-72879]
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: